Remove broken ecl_grav_calc #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_pase_deltag attempted to bind ecl_grav_phase_deltag from the c code, but because ecl_grav_calc.hpp was not included in ecl_grav_calc.cpp, ecl_grav_phase_deltag was given cpp name mangling and not found by cwrap. This has likely not ever worked when compiled with cpp compiler, which it has since 4ff7f76
sondreso
approved these changes
Oct 27, 2023
eivindjahren
force-pushed
the
remove_broken_grav_calc
branch
from
ebb2fec
to
e4ba44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module can be removed as it has not been working for a number of years.